Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile.ubi: fix PYTHON_VERSION arg usage #164

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Dockerfile.ubi: fix PYTHON_VERSION arg usage #164

merged 1 commit into from
Sep 23, 2024

Conversation

dtrifiro
Copy link

@dtrifiro dtrifiro added the lgtm label Sep 17, 2024
@openshift-ci openshift-ci bot removed the lgtm label Sep 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2024

New changes are detected. LGTM label has been removed.

@dtrifiro dtrifiro added the lgtm label Sep 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, NickLucche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [NickLucche,dtrifiro]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NickLucche
Copy link

/retest

1 similar comment
@NickLucche
Copy link

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 18, 2024

@dtrifiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test 5be55c5 link true /test smoke-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dtrifiro dtrifiro merged commit 083f0d5 into opendatahub-io:main Sep 23, 2024
19 of 21 checks passed
@dtrifiro dtrifiro deleted the fix-python-arg-usage branch September 23, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLucche NickLucche NickLucche approved these changes

@rpancham rpancham Awaiting requested review from rpancham

Assignees
No one assigned
Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtrifiro @NickLucche